refactor(workflowengine): Port away from old events#58600
Open
CarlSchwan wants to merge 1 commit intomasterfrom
Open
refactor(workflowengine): Port away from old events#58600CarlSchwan wants to merge 1 commit intomasterfrom
CarlSchwan wants to merge 1 commit intomasterfrom
Conversation
CarlSchwan
requested review from
a team,
blizzz,
juliusknorr and
nickvergessen
as code owners
CarlSchwan
requested review from
artonge,
leftybournes,
nfebe and
sorbaugh
and removed request for
a team
CarlSchwan
force-pushed
the
carl/workflow-outdated-events
branch
from
936cfc7 to
640c4bf
Compare
And enforce via static analysis that only new event classes are used. We have to also create a new private event for the workflowengine as the rule matcher is not able to handle multiple nodes at the same time. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/workflow-outdated-events
branch
from
640c4bf to
0d5c71c
Compare
Contributor
|
Ci looks unhappy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
And enforce via static analysis that only new event classes are used.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)