fix: pass only object key to deleteObjects call#58582
Merged
leftybournes merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
leftybournes
requested review from
CarlSchwan,
come-nc,
salmart-dev and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
cristianscheid
approved these changes
Feb 26, 2026
joshtrichards
approved these changes
Feb 26, 2026
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Makes sense. Zero benefit to Etag here and it's not supported anyway. At best it is a no-op.
Some S3-compatible object storage hosts don't like the ETag being included in the request and return a MalformedXML response. In the AWS API documentation, only the object key is required so just pass that in. Signed-off-by: Kent Delante <kent.delante@proton.me>
leftybournes
force-pushed
the
leftybournes/fix/files_external_delete_objects
branch
from
aac8687 to
8d1cb50
Compare
leftybournes
deleted the
leftybournes/fix/files_external_delete_objects
branch
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/58582/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8d1cb500
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58582/stable31Error: Failed to push branch backport/58582/stable31: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some S3-compatible object storage hosts don't like the ETag being included in the request and return a MalformedXML response. In the AWS API documentation, only the object key is required so just pass that in.
Summary
Follow-up to #56366. Some S3-compatible object storage hosts don't like that the ETag is included in the request and return a MalformedXML response. The AWS S3 API documentation only requires the object key in the deleteObjects request so just pass that in.
Checklist
3. to review, feature component)stable32)