feat: Add SetupCheck to warn about missing second factor provider #57854
+75
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
a team,
ChristophWurst,
miaulalala and
nickvergessen
as code owners
come-nc
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
miaulalala
reviewed
Jan 27, 2026
szaimen
reviewed
Jan 29, 2026
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Some comments. I don't think this should succeed when only backup codes are available. It needs at least one real 2FA provider.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
In practice this filters out backup codes. Also fixed the english formulation and the copyright year. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/add-twofactor-warning
branch
from
bc8c02c to
8475bed
Compare
szaimen
reviewed
Feb 2, 2026
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/add-twofactor-warning
branch
from
f7e0f8e to
26cec2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add warning if no two factor auth provider is found.
Checklist
3. to review, feature component)stable32)