[stable30] fix(S3): Only append streams if non-seekable #55672
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
a team,
ArtificialOwl,
SebastianKrupinski,
come-nc,
hamza221,
icewind1991,
kesselb,
nfebe,
provokateurin,
skjnldsv,
sorbaugh,
st3iny,
susnux,
szaimen and
tcitworld
as code owners
artonge
removed request for
a team,
SebastianKrupinski,
come-nc,
hamza221,
icewind1991,
kesselb,
provokateurin,
skjnldsv,
sorbaugh,
susnux,
szaimen and
tcitworld
artonge
requested review from
leftybournes and
provokateurin
and removed request for
ArtificialOwl,
nfebe and
st3iny
artonge
added
bug
3. to review
provokateurin
approved these changes
Oct 10, 2025
artonge
force-pushed
the
backport/55654/stable30
branch
from
521fd68 to
15aa98a
Compare
|
CI failure unrelated |
susnux
approved these changes
Oct 13, 2025
Later, when we rewind the stream in `writeMultiPart` during retry, both streams were rewinded, so the resulting stream was bigger than expected. Inspired by https://github.com/aws/aws-sdk-php/blob/master/src/S3/ObjectUploader.php#L136-L146 Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
backport/55654/stable30
branch
from
15aa98a to
04ac405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of Backport of PR #55654