fix(contacts): Do not expose SAB in /contactsmenu #55657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
a team,
SebastianKrupinski and
hamza221
as code owners
artonge
added
3. to review
artonge
requested review from
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
artonge
force-pushed
the
artonge/fix/do_not_expose_system_address_book_in_contacts
branch
from
68ba9a7 to
4eaa956
Compare
ChristophWurst
approved these changes
Oct 9, 2025
|
@artonge I think it's better to only backport the first commit. the refactoring will fail on older releases and it's not essential |
kesselb
approved these changes
Oct 10, 2025
artonge
force-pushed
the
artonge/fix/do_not_expose_system_address_book_in_contacts
branch
2 times, most recently
from
8653b32 to
6f97a20
Compare
When hitting the `/contactsmenu/contacts` endpoint with the `dav.system_addressbook_exposed` config switch set to `"no"`, the system address book content is still listed in the response. This ensure that we do not expose unexpectedly the system address book. Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/do_not_expose_system_address_book_in_contacts
branch
from
6f97a20 to
e976a13
Compare
artonge
deleted the
artonge/fix/do_not_expose_system_address_book_in_contacts
branch
|
/backport d14c96b to stable32 |
|
/backport d14c96b to stable31 |
|
/backport d14c96b to stable30 |
|
/backport d14c96b to stable29 |
|
/backport d14c96b to stable28 |
This was referenced Oct 11, 2025
This was referenced Oct 11, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the
/contactsmenu/contactsendpoint with thedav.system_addressbook_exposedconfig switch set to"no", the system address book content is still listed in the response.