Skip to content

Fix comments when used by other apps #55645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2025
Merged

Fix comments when used by other apps #55645

merged 5 commits into from
Oct 10, 2025

Conversation

@nickvergessen
Copy link
Member

Summary

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 33 milestone Oct 9, 2025
@nickvergessen nickvergessen self-assigned this Oct 9, 2025
@nickvergessen nickvergessen requested review from a team as code owners October 9, 2025 09:12
@nickvergessen nickvergessen requested review from nfebe, skjnldsv and sorbaugh and removed request for a team October 9, 2025 09:12
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Oct 9, 2025
@nickvergessen nickvergessen requested review from Altahrim and removed request for a team October 9, 2025 09:12
@nickvergessen nickvergessen requested review from Antreesy, CarlSchwan and susnux and removed request for Altahrim, nfebe and sorbaugh October 9, 2025 09:12
@nickvergessen nickvergessen changed the title Bugfix/noid/comments by apps Fix comments when used by other apps Oct 9, 2025
Antreesy
Antreesy reviewed Oct 9, 2025
View reviewed changes
@nickvergessen nickvergessen requested a review from Antreesy October 9, 2025 09:33
@nickvergessen nickvergessen mentioned this pull request Oct 9, 2025
Merged
susnux
susnux approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

@nickvergessen
fix(comments): Use the correct object when autocompleting mentions fo…
fa17c55 
…r other apps

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(comments): Correctly await the getComments() call
8ab5cf4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(comments): Support user IDs that are numbers, e.g. "42"
d659cbc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(comments): Don't throw type error when no itemType or itemId is g…
d332091 
…iven

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/comments-by-apps branch from 4a35a33 to d332091 Compare October 9, 2025 14:35
@nickvergessen
Copy link
Member Author

/compile /

@nextcloud-command
chore(assets): Recompile assets
4efb40f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nickvergessen nickvergessen merged commit b469840 into master Oct 10, 2025
205 of 209 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/comments-by-apps branch October 10, 2025 06:36
@nickvergessen
Copy link
Member Author

/backport fa17c55 8ab5cf4 d659cbc d332091 to stable32

@nickvergessen
Copy link
Member Author

/backport fa17c55 8ab5cf4 d659cbc d332091 to stable31

This was referenced Oct 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: comments

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

Mentioning with @ not working in Announcement Comments

5 participants

@nickvergessen @susnux @Antreesy @nextcloud-command