Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Oct 8, 2025

Summary

We only need to encode spaces in principal URIs. The rest should stay as is. This is how the Sabre CalDAV backend currently handles the encoding.

Checklist

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added this to the Nextcloud 33 milestone Oct 8, 2025
@st3iny st3iny self-assigned this Oct 8, 2025
@st3iny st3iny requested a review from a team as a code owner October 8, 2025 10:17
@st3iny st3iny added the bug label Oct 8, 2025
@st3iny st3iny requested review from ArtificialOwl and removed request for a team October 8, 2025 10:17
@st3iny st3iny added the 3. to review Waiting for reviews label Oct 8, 2025
@st3iny st3iny added feature: search feature: caldav Related to CalDAV internals labels Oct 8, 2025
@st3iny
Copy link
Member Author

st3iny commented Oct 8, 2025

/backport to stable32

@st3iny
Copy link
Member Author

st3iny commented Oct 8, 2025

/backport to stable31

@provokateurin provokateurin merged commit 6c362cb into master Oct 8, 2025
192 of 194 checks passed
@provokateurin provokateurin deleted the fix/caldav/principal-encoding-inconsistencies branch October 8, 2025 10:56
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Calendar search generates invalid links when username contains spaces

4 participants