Fix admin delegation show all priority items #55462
Conversation
printminion-co
requested review from
come-nc,
salmart-dev and
sorbaugh
and removed request for
a team
in order to be able to better understand priority sorting. php occ admin-delegation:show --output=json_pretty Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
otherwise delegation only from the first priority array ara shown Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
fix/admin_delegation-show-all-priority-items
branch
from
9ce1d37 to
b0ed8b1
Compare
printminion-co
deleted the
fix/admin_delegation-show-all-priority-items
branch
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55462/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 33577b31 b0ed8b14
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55462/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable32 |
4 participants
Summary
Fixes missing output of delegate-able classes omitted before du to error .
Before
Observe missing classes:
After
Test JSON output with priority values
Run before fix:
php occ admin-delegation:show --output=json_pretty
[ { "id": "overview", "name": "Overview", "settings": [ { "name": "Security & setup checks", "className": "OCA\\Settings\\Settings\\Admin\\Overview", "delegatedGroups": [] } ] }, { "id": "server", "name": "Basic settings", "settings": [ { "name": "Background jobs", "className": "OCA\\Settings\\Settings\\Admin\\Server", "delegatedGroups": [] } ] }, { "id": "sharing", "name": "Sharing", "settings": [ { "name": "Global", "className": "OCA\\Settings\\Settings\\Admin\\Sharing", "delegatedGroups": [] } ] }, { "id": "theming", "name": "Theming", "settings": [ { "name": "Global", "className": "OCA\\Theming\\Settings\\Admin", "delegatedGroups": [] } ] }, { "id": "ai", "name": "Assistant", "settings": [ { "name": "Artificial Intelligence", "className": "OCA\\Settings\\Settings\\Admin\\ArtificialIntelligence", "delegatedGroups": [] } ] } ]Result after fix:
php occ admin-delegation:show --output=json_pretty
[ { "id": "overview", "name": "Overview", "settings": [ { "name": "Security & setup checks", "className": "OCA\\Settings\\Settings\\Admin\\Overview", "priority": 10, "delegatedGroups": [] } ] }, { "id": "server", "name": "Basic settings", "settings": [ { "name": "Background jobs", "className": "OCA\\Settings\\Settings\\Admin\\Server", "priority": 0, "delegatedGroups": [] }, { "name": "Email server", "className": "OCA\\Settings\\Settings\\Admin\\Mail", "priority": 10, "delegatedGroups": [] } ] }, { "id": "sharing", "name": "Sharing", "settings": [ { "name": "Global", "className": "OCA\\Settings\\Settings\\Admin\\Sharing", "priority": 0, "delegatedGroups": [] }, { "name": "Federated Cloud Sharing", "className": "OCA\\FederatedFileSharing\\Settings\\Admin", "priority": 20, "delegatedGroups": [] }, { "name": "Trusted servers", "className": "OCA\\Federation\\Settings\\Admin", "priority": 30, "delegatedGroups": [] }, { "name": "Share by mail", "className": "OCA\\ShareByMail\\Settings\\Admin", "priority": 40, "delegatedGroups": [] } ] }, { "id": "theming", "name": "Theming", "settings": [ { "name": "Global", "className": "OCA\\Theming\\Settings\\Admin", "priority": 5, "delegatedGroups": [] } ] }, { "id": "ai", "name": "Assistant", "settings": [ { "name": "Artificial Intelligence", "className": "OCA\\Settings\\Settings\\Admin\\ArtificialIntelligence", "priority": 10, "delegatedGroups": [] } ] } ]Checklist
3. to review, feature component)stable32)