fix: legal footer on public page#55415
Merged
SebastianKrupinski merged 1 commit intomasterfrom Dec 9, 2025
Merged
Conversation
SebastianKrupinski
requested review from
ArtificialOwl,
leftybournes,
nfebe,
skjnldsv and
susnux
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
Merged
ChristophWurst
approved these changes
Dec 9, 2025
core/css/public.scss
Outdated
| height: var(--default-line-height); | ||
| color: var(--color-text-maxcontrast); | ||
| white-space: nowrap; | ||
| display: inline-block; |
Member
There was a problem hiding this comment.
going by the other blocks I think there is one indentation too many
core/css/public.scss
Outdated
| bottom: var(--body-container-margin); | ||
| background-color: var(--color-main-background); | ||
| transform: translateX(-50%); | ||
| background-color: rgba( var(--color-main-background-rgb, 255,255,255), 0.85 ); |
Member
There was a problem hiding this comment.
Suggested change
| background-color: rgba( var(--color-main-background-rgb, 255,255,255), 0.85 ); | |
| background-color: rgba( var(--color-main-background-rgb, 255, 255, 255), 0.85 ); |
Contributor
There was a problem hiding this comment.
The RGB variants are discouraged. Also for consistency with the footer in other places it should be the same as .guestbox in guests.scss:
--color-text-maxcontrast: var(--color-text-maxcontrast-background-blur, var(--color-main-text));
color: var(--color-main-text);
background-color: var(--color-main-background-blur);
-webkit-backdrop-filter: var(--filter-background-blur);
backdrop-filter: var(--filter-background-blur);
SebastianKrupinski
force-pushed
the
fix/issue-legal-footer
branch
from
8066fde to
6569424
Compare
Contributor
Author
|
Updated screen capture 
|
susnux
approved these changes
Dec 9, 2025
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/issue-legal-footer
branch
from
6569424 to
162ebfa
Compare
2 tasks
Contributor
|
This breaks quite some public pages now, as not respecting footerVisible anymore. I see that at least 5 apps (including Calendar) had this specifically disabled: https://github.com/search?q=org%3Anextcloud+setFooterVisible&type=code |
Contributor
Author
|
Hi @Antreesy Thanks for letting me know, I will have to adjust the condition again. |
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)