fix(files): Stop overwriting scan_permissions #55374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
a team,
CarlSchwan,
come-nc and
icewind1991
and removed request for
a team
|
/backport to stable32 |
|
/backport to stable31 |
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/files/overwrite-scan-permissions
branch
from
8b1b267 to
ef279f6
Compare
|
/backport to stable31 |
come-nc
approved these changes
Sep 28, 2025
icewind1991
approved these changes
Sep 29, 2025
This was referenced Sep 29, 2025
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying a file from a groupfolder with ACL will result in a filecache entry with the ACL permissions still applied.
https://github.com/nextcloud/groupfolders/blob/3dfba93b129d5d0f329378c08bdb8c7b7b98d6d5/lib/ACL/ACLCacheWrapper.php#L47-L48 sets
scan_permissionsfirst and then applies the ACL permissions to thepermissions. After that the CachePermissionMasks overwrites thescan_permissionswith thepermissionsthat already include the ACL permissions. tl;dr: Never overwrite thescan_permissionsif they are already set, as they must be the original permissions.