Skip to content

Conversation

@edward-ly
Copy link
Contributor

Summary

Adds an explicit (rather than implicit) return statement in the checkForId function. Otherwise, it will return undefined regardless of whether the comment is in limbo or not, causing comments in limbo to always mistakenly appear.

Before After
Screenshot 2025-09-23 at 23-17-10 All files - Files - Nextcloud Screenshot 2025-09-23 at 23-15-53 All files - Files - Nextcloud

Checklist

Otherwise, the `checkForId` function returns `undefined` regardless of
whether the comment is in limbo or not.

Signed-off-by: Edward Ly <contact@edward.ly>
@edward-ly edward-ly added this to the Nextcloud 33 milestone Sep 24, 2025
@edward-ly edward-ly requested a review from a team as a code owner September 24, 2025 06:19
@edward-ly edward-ly added the bug label Sep 24, 2025
@edward-ly edward-ly removed the request for review from a team September 24, 2025 06:19
@edward-ly edward-ly added the 3. to review Waiting for reviews label Sep 24, 2025
@edward-ly
Copy link
Contributor Author

/backport to stable32

@edward-ly
Copy link
Contributor Author

/backport to stable31

@edward-ly
Copy link
Contributor Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@edward-ly edward-ly enabled auto-merge September 24, 2025 15:43
@edward-ly edward-ly merged commit 77d660e into master Sep 24, 2025
138 of 140 checks passed
@edward-ly edward-ly deleted the fix/comment-is-limbo branch September 24, 2025 15:46
@backportbot
Copy link

backportbot bot commented Sep 24, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/55275/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8858ba12 6f7b3b39

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55275/stable31

Error: Failed to push branch backport/55275/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Comment still shows after being deleted until page refresh

7 participants