-
-
Couldn't load subscription status.
- Fork 4.6k
fix(comments): explicitly return limbo status of comment #55275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Otherwise, the `checkForId` function returns `undefined` regardless of whether the comment is in limbo or not. Signed-off-by: Edward Ly <contact@edward.ly>
|
/backport to stable32 |
|
/backport to stable31 |
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55275/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8858ba12 6f7b3b39
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55275/stable31Error: Failed to push branch backport/55275/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Adds an explicit (rather than implicit)
returnstatement in thecheckForIdfunction. Otherwise, it will returnundefinedregardless of whether the comment is in limbo or not, causing comments in limbo to always mistakenly appear.Checklist
3. to review, feature component)stable32)