Skip to content

perf: log slow DNS operations #55265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf: log slow DNS operations #55265

wants to merge 2 commits into from

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 23, 2025 •
edited
Loading

Summary

DNS can be a bottleneck. This makes the problem visible in the log when the DNS pinning middleware is slowing things down.

TODO

  • Refactor session monitoring into generic trait
  • Wrap dns operation in middleware

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 32 milestone Sep 23, 2025
@ChristophWurst ChristophWurst self-assigned this Sep 23, 2025
@ChristophWurst ChristophWurst requested a review from a team as a code owner September 23, 2025 07:44
@ChristophWurst ChristophWurst removed the request for review from a team September 23, 2025 07:44
@ChristophWurst ChristophWurst mentioned this pull request Sep 23, 2025
Open
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 23, 2025
@ChristophWurst
Copy link
Member Author

/backport to stable32

This was referenced Sep 25, 2025
Merged
Merged
@ChristophWurst ChristophWurst mentioned this pull request Sep 27, 2025
Open
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@ChristophWurst
refactor: extract slow operation logging into trait
a44af27 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
perf: log slow DNS operations
82e8dc5 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug performance 🚀

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @Altahrim @CarlSchwan @skjnldsv