Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 16, 2025

Extracted from #54803
Instead of using the cache to store the temporary avatar (in case it is not square for cropping), the image is just returned as a base64 URI.
The cropping was also done by the frontend already, so the endpoint for cropping in the backend is not needed anymore either, thus removing the necessity of using the cache completely.

@provokateurin provokateurin added this to the Nextcloud 33 milestone Sep 16, 2025
@provokateurin provokateurin requested review from a team as code owners September 16, 2025 08:02
@provokateurin provokateurin requested review from nfebe, sorbaugh and susnux and removed request for a team September 16, 2025 08:02
@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Sep 16, 2025
@provokateurin provokateurin requested review from yemkareems and removed request for a team September 16, 2025 08:02
@provokateurin
Copy link
Member Author

/backport to stable32

@provokateurin
Copy link
Member Author

/backport to stable31

@provokateurin
Copy link
Member Author

/backport to stable30

Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👏

Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/core/user-avatar-upload branch from e3ba2c0 to dfa9fce Compare September 25, 2025 11:12
@provokateurin provokateurin merged commit 442a19b into master Sep 25, 2025
210 of 213 checks passed
@provokateurin provokateurin deleted the fix/core/user-avatar-upload branch September 25, 2025 11:39
@backportbot
Copy link

backportbot bot commented Sep 25, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/55134/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bfb4fe8f dfa9fce4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55134/stable30

Error: Failed to push branch backport/55134/stable30: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member Author

/backport to stable32

@provokateurin
Copy link
Member Author

/backport to stable31

@backportbot
Copy link

backportbot bot commented Sep 25, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55134/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bfb4fe8f dfa9fce4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55134/stable32

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/55134/stable32."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member Author

/backport to stable30

@backportbot
Copy link

backportbot bot commented Sep 25, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/55134/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bfb4fe8f dfa9fce4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55134/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/55134/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants