-
-
Couldn't load subscription status.
- Fork 4.6k
fix(core): Stop abusing the cache for avatar upload #55134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable32 |
|
/backport to stable31 |
|
/backport to stable30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup 👏
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
e3ba2c0 to
dfa9fce
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/55134/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bfb4fe8f dfa9fce4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55134/stable30Error: Failed to push branch backport/55134/stable30: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable32 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/55134/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bfb4fe8f dfa9fce4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55134/stable32Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/55134/stable32."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/55134/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bfb4fe8f dfa9fce4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55134/stable31Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/55134/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Extracted from #54803
Instead of using the cache to store the temporary avatar (in case it is not square for cropping), the image is just returned as a base64 URI.
The cropping was also done by the frontend already, so the endpoint for cropping in the backend is not needed anymore either, thus removing the necessity of using the cache completely.