-
-
Couldn't load subscription status.
- Fork 4.6k
fix(sharing): Adapt share suggestions to match trusted servers configs #55080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dd038fb to
7dca29b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not fully understand how this is possible only on backend side.
Because with "show trusted servers as internal" the search request from the frontend is basically the same, both "internal shares" and "external shares" will search for remote type.
The difference is only that with "show trusted servers as internal" that only trusted servers should be shown in the "internal share" results, while all other remotes should still be listed in "external shares" results
7dca29b to
9763088
Compare
|
/backport to stable-31 |
9763088 to
cfda889
Compare
3e3a68b to
e93743f
Compare
|
/compile |
600912f to
e08c77b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the typing error, looks good
28ab7bf to
c68b379
Compare
c68b379 to
09f100c
Compare
|
/compile |
7a2d805 to
b4654f7
Compare
|
/compile |
8eedbac to
7a9c82c
Compare
|
/compile |
65dfd15 to
2467faf
Compare
When `show_federated_shares_to_trusted_servers_as_internal` is enabled but `show_federated_shares_as_internal` is not, filter federated share suggestions to only include trusted servers. Previously, searching for an email address would suggest non-trusted federated servers. Resolved: #54511 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2467faf to
c9bb6ee
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable-31
git pull origin stable-31
# Create the new backport branch
git checkout -b backport/55080/stable-31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c1d9e22c c9bb6eed 8c7be09d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55080/stable-31Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/55080/stable-31') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable32 |
|
/backport to stable31 |
When
show_federated_shares_to_trusted_servers_as_internalis enabled butshow_federated_shares_as_internalis not, filter federated share suggestions to only include trusted servers. Previously, searching for an email address would suggest non-trusted federated servers.Resolved: #54511