fix(cache): Set default Redis port to 0 for UNIX sockets
#54941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using phpredis with a UNIX socket, the port should either not be specified at all or be `<1`. https://github.com/phpredis/phpredis?tab=readme-ov-file#connect-open https://github.com/phpredis/phpredis/blob/d0b0c5cfdde9d49a265ca4bf7184e3998863aed0/library.c#L3332-L3334 Fixes #54813 Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
come-nc and
icewind1991
and removed request for
a team
joshtrichards
added
bug
3. to review
|
/backport to stable32 |
|
/backport to stable31 |
solracsf
approved these changes
Sep 7, 2025
come-nc
approved these changes
Sep 8, 2025
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using phpredis with a UNIX socket, the port should either not be specified at all or be
<1.https://github.com/phpredis/phpredis?tab=readme-ov-file#connect-open
https://github.com/phpredis/phpredis/blob/d0b0c5cfdde9d49a265ca4bf7184e3998863aed0/library.c#L3332-L3334
TODO
Checklist