[stable31] reuse check

[kesselb]

For unknown reasons, the reuse check is failing despite a definition being available in .reuse/dep5 🤷

[AndyScherzinger]

@kesselb is that license file only in the settings in an invisible way or will it be copied over to the users' data?

Afk, else could also check ich the version in use of the reuse action

[kesselb]

I think that PDF is used by

server/apps/settings/lib/Controller/ReasonsController.php

Line 26 in acb26a4

$data = file_get_contents(__DIR__ . '/../../data/Reasons to use Nextcloud.pdf');

The examples in the homedir are coming from https://github.com/nextcloud/example-files/ afaik.

I can take a second look later.

[kesselb]

The examples in the homedir are coming from https://github.com/nextcloud/example-files/ afaik.

The example files are copied to core/skeleton during the build. The only reference to the file in apps/settings/data/ is from the ReasonsController. Unless someone set the skeletondirectory to apps/settings/data, we do not copy the contents of the folder somewhere.

also check ich the version in use of the reuse action

The reuse action wasn't update recently, but the action is fetching the latest version of the resuse-tools and something there must have changed.

Good:

docker run --rm --volume $(pwd):/data fsfe/reuse:5@sha256:000c3fc0c3e39e95b36fa9966d0104ae0496571b7de7b9f0c889a66438581bda lint

Bad:

docker run --rm --volume $(pwd):/data fsfe/reuse:5@sha256:f89e2e1284685463a8b3486371dcd7547af564ccec546ff08db00f9c072b85a7 lint

It seems that only .reuse/dep5 is affected, because the same version on master/stable32, where we are using REUSE.toml, does not complain.

Adding the .license file looks like the easiest solution. Given the low impact, I’d wait to merge it until 31/30 final are out. Ideally, we won’t have any more merges for stable31 since it’s in freeze.

[AndyScherzinger]

Sounds good, the other easy solution would be pinning the reuse action by the latest commit hash that worked. Either one is fine 👍

[st3iny]

/backport to stable30

[st3iny]

Fixes CI 🥳

[AndyScherzinger]

to be merged after the code-freeze

[kesselb]

Superseeded by #54979