perf(base): Stop setting up the FS for every basic auth request #54803
+19
−376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
nfebe,
sorbaugh,
susnux,
szaimen and
yemkareems
and removed request for
a team
|
/compile |
1 task
|
susnux
approved these changes
Sep 2, 2025
szaimen
requested review from
come-nc and
skjnldsv
and removed request for
szaimen
|
Deck will also need a testing PR for this branch, as it relies on the same logic that is currently breaking Talk sharing tests (but I already have a solution): https://github.com/nextcloud/spreed/actions/runs/17404020365/job/49403633071?pr=15777 |
provokateurin
force-pushed
the
perf/base/basic-auth-fs-setup
branch
from
6511d14 to
7500e26
Compare
|
I ran all the failing Talk and Deck integration tests locally, but they all pass 🙈 I double checked that I'm really using the correct branches, but it was all as intended. |
This was referenced Sep 16, 2025
provokateurin
force-pushed
the
perf/base/basic-auth-fs-setup
branch
3 times, most recently
from
b0e3fba to
aced6e3
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
… local cache Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
perf/base/basic-auth-fs-setup
branch
from
aced6e3 to
0786ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more time, we're gonna celebrate 🎵 ✌️ (last time, I promise 🤞)
Needs #31357 to not break the Guests app.
Nothing needed to change on the server side, it's the exact same changes as with the last PR.