Skip to content

[stable31] fix: aliases and capitalization of emails #54771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

[stable31] fix: aliases and capitalization of emails #54771

merged 1 commit into from
Sep 16, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Aug 31, 2025 •
edited by SebastianKrupinski
Loading

Backport of #52622

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Aug 31, 2025
@backportbot backportbot bot added this to the Nextcloud 31.0.9 milestone Aug 31, 2025
st3iny
st3iny requested changes Sep 1, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not export the public API change. Manager::handleImip should be a private method, not present in IManager.

@SebastianKrupinski
Copy link
Contributor

Please do not export the public API change. Manager::handleImip should be a private method, not present in IManager.

Done, but I had to make it protected so that I could mock it in the Request, Reply and Cancel tests

@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review September 8, 2025 23:07
st3iny
st3iny approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@st3iny
Copy link
Member

st3iny commented Sep 9, 2025

Reuse CI fix at #54923

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 9, 2025
@SebastianKrupinski
Copy link
Contributor

Reuse CI fix at #54923

👍 I'll rebase this after the other PR is merged

@nextcloud-bot nextcloud-bot mentioned this pull request Sep 10, 2025
Merged
17 tasks
@SebastianKrupinski @AndyScherzinger
fix: aliases and capitalization of emails
e25d0db 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@AndyScherzinger AndyScherzinger merged commit 97af34f into stable31 Sep 16, 2025
206 of 212 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/52622/stable31 branch September 16, 2025 20:57
@blizzz blizzz mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 31.0.10

Development

Successfully merging this pull request may close these issues.

3 participants

@SebastianKrupinski @st3iny @AndyScherzinger