Skip to content

fix(2fa): Fix 2FA session setup when ephemeral session is used #54605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

fix(2fa): Fix 2FA session setup when ephemeral session is used #54605

merged 1 commit into from
Aug 26, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 25, 2025 •
edited
Loading

  • Enable 2FA
  • Enforce 2FA
  • As a user that did not yet setup 2FA start a login flow v2 (e.g. files desktop client)

Before

Bildschirmfoto vom 2025-08-25 10-43-22 image

After

Bildschirmfoto vom 2025-08-25 10-42-34

Checklist

@nickvergessen
fix(2fa): Fix 2FA session setup when ephemeral session is used
11aa997 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 32 milestone Aug 25, 2025
@nickvergessen nickvergessen self-assigned this Aug 25, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner August 25, 2025 08:44
@nickvergessen nickvergessen requested review from leftybournes, nfebe and salmart-dev and removed request for a team August 25, 2025 08:44
@nickvergessen
Copy link
Member Author

/backport to stable31

@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen
Copy link
Member Author

/backport to stable27

@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen
Copy link
Member Author

/backport to stable25

@nextcloud-bot nextcloud-bot mentioned this pull request Aug 25, 2025
Merged
@nickvergessen
Copy link
Member Author

Certs were fixed with #54608

@nickvergessen nickvergessen merged commit c9712b4 into master Aug 26, 2025
211 of 230 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-2fa-setup-during-ephemeral-session branch August 26, 2025 13:45
@backportbot backportbot bot mentioned this pull request Aug 26, 2025
Merged
This was referenced Aug 26, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 28, 2025
Merged
@nickvergessen nickvergessen mentioned this pull request Sep 17, 2025
Open
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge artonge approved these changes

@provokateurin provokateurin provokateurin approved these changes

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: authentication

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @ChristophWurst @artonge @provokateurin @skjnldsv