Skip to content

feat(file_sharing): Provide template creator list in public shares #54565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2025
Merged

feat(file_sharing): Provide template creator list in public shares #54565

merged 2 commits into from
Sep 8, 2025

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Aug 21, 2025 •
edited
Loading

Fix #48064

@artonge artonge requested review from a team and skjnldsv as code owners August 21, 2025 14:23
@artonge artonge requested review from Altahrim, ArtificialOwl, susnux, szaimen and yemkareems and removed request for a team August 21, 2025 14:23
@artonge artonge self-assigned this Aug 21, 2025
@artonge artonge added enhancement 3. to review Waiting for reviews feature: sharing javascript php Pull requests that update Php code labels Aug 21, 2025
@artonge artonge force-pushed the artonge/feat/support_template_in_public_shares branch from b8a12c9 to 55c8d86 Compare August 21, 2025 14:26
@artonge
Copy link
Contributor Author

artonge commented Aug 21, 2025

/backport to stable31

@artonge
Copy link
Contributor Author

artonge commented Aug 21, 2025

/backport to stable30

@artonge
Copy link
Contributor Author

artonge commented Aug 21, 2025

/compile rebase

susnux
susnux reviewed Aug 21, 2025
View reviewed changes
@nextcloud-command nextcloud-command force-pushed the artonge/feat/support_template_in_public_shares branch from 55c8d86 to 3bad9d1 Compare August 21, 2025 15:15
@artonge artonge force-pushed the artonge/feat/support_template_in_public_shares branch 3 times, most recently from c84d96e to d22300e Compare August 25, 2025 13:14
@artonge artonge force-pushed the artonge/feat/support_template_in_public_shares branch 2 times, most recently from 1bc63c1 to ba33875 Compare August 25, 2025 13:54
@camilasan
Copy link
Member

feedback from @elzody:
The button shows up now in the New File menu, but unable to create a text file. Getting this error:

{
    "ocs": {
        "meta": {
            "status": "failure",
            "statuscode": 997,
            "message": "Current user is not logged in"
        },
        "data": []
    }
}

Seems like the route is protected and requires a logged-in user even though it's a public share with total edit permissions

@artonge artonge force-pushed the artonge/feat/support_template_in_public_shares branch 2 times, most recently from 04dd924 to 760c86f Compare August 28, 2025 15:46
@artonge
Copy link
Contributor Author

artonge commented Aug 28, 2025

@camilasan @elzody just pushed an update, to also handle the file creation. Can you test it?

@camilasan
Copy link
Member

camilasan commented Sep 1, 2025 •
edited
Loading

@camilasan @elzody just pushed an update, to also handle the file creation. Can you test it?

I again failed to run your changes. I have pinged @elzody for help testing it 😬

elzody
elzody approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a try, it seems to work fine on my end.

@camilasan
Copy link
Member

backport to stable31 now?

@artonge artonge force-pushed the artonge/feat/support_template_in_public_shares branch from 760c86f to 01cb346 Compare September 4, 2025 10:14
@artonge
Copy link
Contributor Author

artonge commented Sep 4, 2025

/compile rebase

artonge and others added 2 commits September 4, 2025 12:13
@artonge @nextcloud-command
fix(encryption): Correctly set encrypted to 0 when copying
6d672c4 
If encryption got disabled, copying should set encrypted to 0 for the
 new unencrypted copy. For instance when using encryption:decrypt-all

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@nextcloud-command
chore(assets): Recompile assets
10d0d0f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the artonge/feat/support_template_in_public_shares branch from 01cb346 to 10d0d0f Compare September 4, 2025 12:20
@artonge
Copy link
Contributor Author

artonge commented Sep 4, 2025

/backport 6d672c4 to stable32

@artonge
Copy link
Contributor Author

artonge commented Sep 4, 2025

/backport 6d672c4 to stable31

@artonge artonge requested a review from susnux September 4, 2025 14:45
@AndyScherzinger AndyScherzinger added this to the Nextcloud 33 milestone Sep 5, 2025
@artonge artonge merged commit 491c64d into master Sep 8, 2025
228 of 238 checks passed
@artonge artonge deleted the artonge/feat/support_template_in_public_shares branch September 8, 2025 10:23
This was referenced Sep 8, 2025
Merged
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
@juliusknorr juliusknorr mentioned this pull request Oct 14, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@elzody elzody elzody approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews enhancement feature: sharing javascript php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Bring new template file creation to public share links

8 participants

@artonge @camilasan @susnux @elzody @AndyScherzinger @skjnldsv @nextcloud-command