fix(files_sharing): sharing status action sidebar promise return #54410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@susnux I wonder why my linter haven't caught this 🤔 |
CarlSchwan
previously approved these changes
Aug 13, 2025
This comment was marked as resolved.
This comment was marked as resolved.
susnux
reviewed
Aug 13, 2025
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
fix/sharing-status-action-sidebar-promise-return
branch
3 times, most recently
from
35792c9 to
4437aad
Compare
skjnldsv
requested review from
CarlSchwan and
susnux
and removed request for
sorbaugh
|
Resolved, this should be better. |
skjnldsv
force-pushed
the
fix/sharing-status-action-sidebar-promise-return
branch
2 times, most recently
from
f284f57 to
2a14928
Compare
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/sharing-status-action-sidebar-promise-return
branch
from
2a14928 to
1b2d81a
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/sharing-status-action-sidebar-promise-return
branch
from
1b2d81a to
ce41a2d
Compare
|
/compile |
susnux
approved these changes
Aug 20, 2025
There was a problem hiding this comment.
ℹ️ Needs to be added to the release script
| if ((node.permissions & Permission.READ) !== 0) { | ||
| window.OCA?.Files?.Sidebar?.setActiveTab?.('sharing') | ||
| return sidebarAction.exec(node, view, dir) | ||
| sidebarAction.exec(node, view, dir) |
There was a problem hiding this comment.
IMHO its better to await it here so that we can trust all work is done and not pending branches exist
Suggested change
| sidebarAction.exec(node, view, dir) | |
| await sidebarAction.exec(node, view, dir) |
There was a problem hiding this comment.
Yeah, I thought about it, I kinda thought I would be confortable awaiting for the sidebar when we'll have it properly re-written with the right api and Node usage 🙈
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
approved these changes
Aug 21, 2025
|
/backport 9404059 to stable31 |
|
/backport 9404059 to stable30 |
|
/backport 9404059 to stable29 |
2 tasks
This was referenced Aug 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The sidebar action is returning a promise, we should await so our own exec also returns the proper value.
This fixes some edge case where opening the sharing options leave the loading indicator spinning
Checklist