Skip to content

fix: don't update cached mountpoints if the request doesn't have filesystem access #54182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

fix: don't update cached mountpoints if the request doesn't have filesystem access #54182

merged 1 commit into from
Aug 1, 2025

Conversation

@icewind1991
Copy link
Member

This would clear all cached mounts for the user.

To test:

  • Create a new app password and uncheck "Allow filesystem access"
  • Note the current state of the oc_mounts table with select count(id), max(id) from oc_mounts;
  • Make a request that authenticates with the new app password.
  • Note the new state of the oc_mounts table with select count(id), max(id) from oc_mounts;

@icewind1991
fix: don't update cached mountpoints if the request doesn't have file…
73d0418 
…system access

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Jul 31, 2025
@icewind1991 icewind1991 requested a review from a team as a code owner July 31, 2025 16:31
@icewind1991 icewind1991 requested review from ArtificialOwl and removed request for a team July 31, 2025 16:31
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 31, 2025
st3iny
st3iny approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@st3iny st3iny merged commit 976e423 into master Aug 1, 2025
226 of 232 checks passed
@st3iny st3iny deleted the mount-cache-without-fs-access branch August 1, 2025 08:32
@icewind1991
Copy link
Member Author

/backport to stable31

@icewind1991
Copy link
Member Author

/backport to stable30

@icewind1991
Copy link
Member Author

/backport to stable29

@backportbot backportbot bot mentioned this pull request Aug 1, 2025
Merged
This was referenced Aug 1, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@Altahrim Altahrim Altahrim approved these changes

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @st3iny @Altahrim @provokateurin @skjnldsv