fix(AppMenu): ensure that aria attributes are set when needed #54172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
leftybournes,
nfebe,
skjnldsv and
szaimen
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
skjnldsv
approved these changes
Aug 1, 2025
|
/compile rebase |
skjnldsv
added
4. to release
We hide **if** there is **no** notification. We *do not* hide and *show the label* **if** there are notifications for that application. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/app-icon-aria
branch
from
c05c96a to
4af6586
Compare
This was referenced Aug 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We hide if there is no notification.
We do not hide and show the label if there are notifications for that application.
Checklist