Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 31, 2025

Summary

nextcloud-vue-collections is deprecated for quite some time and was merged into @nextcloud/vue. So lets drop that dependency.

Adjust the two files where it was used, one of them was itself never used so just dropped that file.

Checklist

…stead

`nextcloud-vue-collections` is deprecated for quite some time and was
merged into `@nextcloud/vue`. So lets drop that dependency.

Adjust the two files where it was used, one of them was itself never
used so just dropped that file.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 32 milestone Jul 31, 2025
@susnux susnux added 3. to review Waiting for reviews dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jul 31, 2025
@susnux susnux marked this pull request as ready for review July 31, 2025 12:02
@susnux susnux requested review from a team as code owners July 31, 2025 12:02
@susnux susnux requested review from leftybournes, nfebe, skjnldsv, sorbaugh and szaimen and removed request for a team and sorbaugh July 31, 2025 12:02
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux
Copy link
Contributor Author

susnux commented Jul 31, 2025

/compile

@susnux
Copy link
Contributor Author

susnux commented Jul 31, 2025

/backport! to stable31

@backportbot

This comment was marked as resolved.

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 31, 2025

/compile rebase

EDIT: cancelled, I thought there would be conflicts with a PR I just merged in between, but no.
LGTM! 🚀

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 31, 2025
@skjnldsv skjnldsv merged commit b4803f9 into master Jul 31, 2025
131 of 136 checks passed
@skjnldsv skjnldsv deleted the chore/remove-deprecated-package branch July 31, 2025 13:36
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants