[stable30] Fix endless spinner on file entries after triggering an action

[danxuliu]

Summary

Fixes a regression introduced in 64cc7af

The fix is not needed in Nextcloud 31 and later, as it was indirectly fixed in 74b2562

When the toast shown while a file is being moved or copied was introduced in 64cc7af an additional condition was added to the isLoading check of file entries. However, that additional condition caused an endless loading spinner to be shown on file entries of the Shares view (but not in other views) after an action was triggered. Turns out that the condition was not actually needed for the toast, so now it is removed again to solve the endless loading spinner.

However, note something strange is going on. If breakpoints are added for isLoading and when loading is set and reset the loading spinner is gone. The loading spinner is also gone if there are no breakpoints, but instead of changing isLoading to:

		isLoading() {
			return this.source.status === NodeStatus.LOADING
		},

it is changed to:

		isLoading() {
			console.log("Check isLoading", this.source, this.loading)
			return this.source.status === NodeStatus.LOADING || this.loading !== ''
		},

It looks like the problem is related to reactivity and how the computed value is updated... but I do not really know. Therefore this pull request just fixes the regression, but not the underlying issue.

Moreover, fixing the regression also uncovers another issue (which was happening already before the regression was introduced): there is no loading spinner for file entries in the Share views while an action is being executed. However, this also happens in current master, so it is unrelated to this fix and should be addressed in another pull request (but please note that it should be done by someone with good knowledge about Vue and the Files app frontend, so that means it will not be me ;-) ).

How to test

• Open the Files app
• Share a file
• Open the Shares view
• Open the actions menu for the shared file
• Click Move or copy
• A spinner is shown on the checkbox of the file entry
• Close the dialog, thus cancelling the action

Result with this pull request

The spinner is removed from the checkbox of the file entry

Result without this pull request

An endless spinner is shown on the checkbox of the file entry

[danxuliu]

/compile /