Skip to content

[stable30] fix: Use default share folder of the user on share accept #54132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2025
Merged

[stable30] fix: Use default share folder of the user on share accept #54132

merged 3 commits into from
Aug 5, 2025

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jul 29, 2025

Backport of PR #51602

come-nc added 2 commits July 29, 2025 09:22
@come-nc @backportbot
fix: Use default share folder of the user on share accept
32dc724 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @backportbot
chore(tests): Adapt DefaultShareProviderTest to new constructor param…
3dac679 
…eter

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@backportbot backportbot bot added this to the Nextcloud 30.0.14 milestone Jul 29, 2025
@provokateurin provokateurin enabled auto-merge July 29, 2025 09:27
@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2025 •
edited
Loading

Related
ArgumentCountError: Too few arguments to function OC\Share20\DefaultShareProvider::__construct(), 11 passed in /home/runner/actions-runner/_work/server/server/lib/private/Share20/ProviderFactory.php on line 91 and exactly 12 expected in /home/runner/actions-runner/_work/server/server/lib/private/Share20/DefaultShareProvider.php:49

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 1, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 5, 2025
Merged
5 tasks
@come-nc
chore: Adapt ProviderFactory to change in DefaultShareProvider constr…
1506b79 
…uctor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 5, 2025
@provokateurin provokateurin merged commit d4ab891 into stable30 Aug 5, 2025
177 checks passed
@provokateurin provokateurin deleted the backport/51602/stable30 branch August 5, 2025 20:12
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 18, 2025
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 25, 2025
Merged
2 tasks
@blizzz blizzz mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@come-nc come-nc

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing

Projects

None yet

Milestone

Nextcloud 30.0.14

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @provokateurin @come-nc