-
-
Couldn't load subscription status.
- Fork 4.6k
fix: validate written size for s3 multipart uploads #54125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wasn't able to figure out a good solution for single part uploads so far, but smaller files should be less likely to be canceled anyway 🙈 |
0ecec88 to
2687b73
Compare
2687b73 to
214280f
Compare
Ok, I think setting the |
52e5c09 to
c762e86
Compare
8ab626b to
7d3ede0
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
7d3ede0 to
97efc95
Compare
|
/backport to stable31 |
For multi-part s3 uploads, validate that the chunks add up to the expected size before completing the upload.
This prevents partially uploaded files from being saved in s3.
To test:
curl)This fix applies both on newly created file and overwritten files.