fix(search): Fix SearchComposer.php filtering logic

[printminion-co]

Summary

keep the $this->providers types

Test via

./occ config:app:set --value '["files","settings"]' --type array core unified_search.providers_allowed

should be part of 8e57004

Tests can be executed via

 composer run test -- tests/lib/Search/SearchComposerTest.php

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

The filtering should be on array keys instead, no? To be able to select providers, not applications? Otherwise you cannot allow settings_apps but not settings, or the other way around.

[printminion-co]

The filtering should be on array keys instead, no? To be able to select providers, not applications? Otherwise you cannot allow settings_apps but not settings, or the other way around.

Initial idea was to Reduce provider loaded in loadLazyProviders method build in here https://github.com/nextcloud/server/pull/54120/files#diff-b892980bbda0284c7230f57fd9c5a658b81d5dbfc8cd51fba24be61d4250799bL104-L107

Unfortunately we destroyed the format of providers from array<string, array{appId: string, provider: IProvider}> to be an array. This should fix it.

[Copilot]

Pull Request Overview

This PR fixes the filtering logic in SearchComposer.php to properly maintain provider types when filtering based on allowed providers configuration. The key issue was that the original implementation converted an associative array to a numeric array, losing the provider ID keys needed for proper provider access.

Key Changes:

• Modified filterProviders() method to work in-place on the instance properties rather than returning a filtered array
• Updated the filtering logic to preserve associative array structure by using unset() instead of array_filter()
• Added comprehensive test coverage for the SearchComposer functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/private/Search/SearchComposer.php	Fixed filtering logic to preserve provider array structure and maintain type consistency
tests/lib/Search/SearchComposerTest.php	Added comprehensive test suite covering provider filtering, ordering, and edge cases

Comments suppressed due to low confidence (1)

tests/lib/Search/SearchComposerTest.php:253

• The test only verifies that the icon contains a specific path pattern but doesn't validate the actual icon generation logic. Consider testing the URL generator mock was called with the correct parameters (appId='app1', imageName='provider1.svg').

		$this->assertStringContainsString('/apps/provider1/img/provider1.svg', $providers[0]['icon']);

[come-nc]

Good apart from nitpick in test.

[come-nc]

see also the code style failure: https://github.com/nextcloud/server/actions/runs/16743727995/job/47397286355?pr=54120

Fix by hand or use composer run cs:fix.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[sorbaugh]

/backport to stable31

[sorbaugh]

/backport to stable30