Skip to content

[stable31] fix(appconfig): mark searchKeys() as internal until 32 #54042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

[stable31] fix(appconfig): mark searchKeys() as internal until 32 #54042

merged 1 commit into from
Jul 30, 2025

Conversation

@ArtificialOwl
Copy link
Member

only for internal uses

@ArtificialOwl ArtificialOwl force-pushed the fix/noid/mark-searchkeys-as-internal branch from 2f03607 to 5e18238 Compare July 22, 2025 13:07
provokateurin
provokateurin requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment @see searchKeys to not load lazy config keys on getKeys should be removed as well.

@ArtificialOwl
Copy link
Member Author

The comment @see searchKeys to not load lazy config keys on getKeys should be removed as well.

nice catch

@ArtificialOwl
fix(appconfig): mark searchKeys() as internal until 32
c15b7aa 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/mark-searchkeys-as-internal branch from 5e18238 to c15b7aa Compare July 22, 2025 13:21
@provokateurin provokateurin merged commit 0289c68 into stable31 Jul 30, 2025
214 of 225 checks passed
@provokateurin provokateurin deleted the fix/noid/mark-searchkeys-as-internal branch July 30, 2025 20:00
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 5, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebe nfebe nfebe approved these changes

@provokateurin provokateurin provokateurin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArtificialOwl @nfebe @provokateurin