Skip to content

fix(bruteforce): limit appconfig lazy loading #54007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

fix(bruteforce): limit appconfig lazy loading #54007

merged 1 commit into from
Jul 21, 2025

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jul 19, 2025 •
edited
Loading

using searchKeys() instead of getKeys() to avoid useless loading of lazy config value

require: #54003

@ArtificialOwl ArtificialOwl requested a review from a team as a code owner July 19, 2025 00:57
@ArtificialOwl ArtificialOwl requested review from leftybournes, nfebe and yemkareems and removed request for a team July 19, 2025 00:57
@ArtificialOwl ArtificialOwl mentioned this pull request Jul 19, 2025
Merged
1 task
@ArtificialOwl
fix(bruteforce): limit appconfig lazy loading
484491e 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/no-lazy-loading-on-isBypassListed branch from 29f3776 to 484491e Compare July 20, 2025 01:49
Base automatically changed from enh/noid/appconfig-get-fast-keys to master July 21, 2025 10:27
@ArtificialOwl ArtificialOwl merged commit 30fb9e3 into master Jul 21, 2025
267 of 293 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/no-lazy-loading-on-isBypassListed branch July 21, 2025 13:03
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@yemkareems yemkareems yemkareems approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtificialOwl @susnux @yemkareems