fix: Do not show password dialog when user can not validate password #54005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The password confirmation dialog is always shown unless the user backend does not allow password confirmation. A user backend may explicitly provide that information, but even if it does not that could have been defined in the authentication token with "IToken::SCOPE_SKIP_PASSWORD_VALIDATION" (for example, when "user_oidc" is only used for authentication and user provision is done by another user backend). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable31 |
|
/backport to stable30 |
danxuliu
added
3. to review
danxuliu
requested review from
ArtificialOwl,
icewind1991,
julien-nc and
skjnldsv
and removed request for
a team
julien-nc
approved these changes
Jul 21, 2025
danxuliu
deleted the
do-not-show-password-dialog-when-user-can-not-validate-password
branch
This was referenced Jul 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #50465
Related to #53472
The password confirmation dialog (which is used, for example, in external storages) is always shown unless the user backend does not allow password confirmation. A user backend may explicitly provide that information, but even if it does not that could have been defined in the authentication token with
IToken::SCOPE_SKIP_PASSWORD_VALIDATION(for example, whenuser_oidcis only used for authentication and user provision is done by another user backend).How to test
Failed to provision the userwould be shown when logging in, as user_oidc is being used only for authentication and the user should be provisioned by another user backend)Result with this pull request
No password confirmation dialog is shown and the external storage is saved
Result without this pull request
A password confirmation dialog is shown