caldav: show confidential event if writable #53988
Conversation
Arusekk
force-pushed
the
cal-edit-private-event
branch
from
d33cccc to
583dfe1
Compare
Arusekk
changed the title
Arusekk
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
skjnldsv
added
3. to review
|
Thank you for submitting this @Arusekk 👏 @SebastianKrupinski @st3iny could you please review and check if the approach makes sense? |
|
On it |
st3iny
force-pushed
the
cal-edit-private-event
branch
from
583dfe1 to
e2d5a06
Compare
If a party can edit the calendar/event, just display it instead of hiding the details and risking overwrites. This might be considered a change impacting privacy, but it actually improves semantics. Relevant test updates included, improving assertion correctness. I think all the relevant use cases are solved by this. Closes nextcloud#5551 Closes nextcloud/calendar#4044 Closes nextcloud#11214 Signed-off-by: Arusekk <floss@arusekk.pl> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
cal-edit-private-event
branch
from
e2d5a06 to
f9b96ca
Compare
|
Unfortunately, we need to import the PR as some CI actions won't run otherwise. Continued here: #54533 |
4 participants
Summary
If a party can edit the calendar/event, just display it instead of hiding the details and risking overwrites. This is the simplest solution that addresses all related issues to some degree.
Closes #5551
Closes nextcloud/calendar#4044
Closes #11214
Checklist