Skip to content

fix(provisioning_api): catch failed user creation #53909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix(provisioning_api): catch failed user creation #53909

merged 1 commit into from
Jul 28, 2025

Conversation

@skjnldsv
Copy link
Member

Caught on a backport, the createUser can return false

image

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jul 11, 2025
@skjnldsv skjnldsv self-assigned this Jul 11, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner July 11, 2025 07:18
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Jul 11, 2025
@skjnldsv skjnldsv requested review from ArtificialOwl and removed request for a team July 11, 2025 07:18
@skjnldsv skjnldsv force-pushed the fix/newUser-provisioning_api branch from 47a9f20 to 0ec5553 Compare July 11, 2025 07:27
@skjnldsv skjnldsv mentioned this pull request Jul 11, 2025
Merged
@skjnldsv skjnldsv requested a review from come-nc July 11, 2025 09:01
@skjnldsv
Copy link
Member Author

/backport to stable31

@skjnldsv
Copy link
Member Author

/backport to stable30

@skjnldsv skjnldsv enabled auto-merge July 11, 2025 12:16
@skjnldsv skjnldsv force-pushed the fix/newUser-provisioning_api branch from 0ec5553 to 1045e26 Compare July 11, 2025 13:34
@skjnldsv
fix(provisioning_api): catch failed user creation
74d6494 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/newUser-provisioning_api branch from 1045e26 to 74d6494 Compare July 14, 2025 08:34
come-nc
come-nc approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the code it feels like this cannot happen unless really corner case like Database backend is disabled. But still better to respect the interface documented return type.

@skjnldsv skjnldsv disabled auto-merge July 28, 2025 07:21
@skjnldsv skjnldsv merged commit 12c07f9 into master Jul 28, 2025
198 of 205 checks passed
@skjnldsv skjnldsv deleted the fix/newUser-provisioning_api branch July 28, 2025 07:21
This was referenced Jul 28, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: users and groups technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @provokateurin @come-nc