Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 3, 2025

Summary

This prevents the profile to look distorted when the primary action is a long email address.

Checklist

This prevents the profile to look distorted when the primary action is a
long email address.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 32 milestone Jul 3, 2025
@susnux susnux requested a review from a team as a code owner July 3, 2025 11:09
@susnux susnux requested review from artonge, sorbaugh and szaimen and removed request for a team July 3, 2025 11:09
@susnux susnux added bug 3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Jul 3, 2025
@susnux susnux requested review from skjnldsv and removed request for artonge July 3, 2025 11:09
@susnux
Copy link
Contributor Author

susnux commented Jul 3, 2025

/backport to stable31

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux
Copy link
Contributor Author

susnux commented Jul 3, 2025

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command requested a review from a team as a code owner July 3, 2025 12:04
@susnux susnux merged commit 6d8ef87 into master Jul 3, 2025
152 of 160 checks passed
@susnux susnux deleted the fix/profile-visibility branch July 3, 2025 14:26
arturhg pushed a commit to arturhg/nextcloud-server that referenced this pull request Jul 4, 2025
- Add comprehensive E2E tests for profile max-width fix
- Test long email addresses that would cause layout distortion
- Validate CSS properties (max-width: 300px for user-actions)
- Include visual regression tests for different email lengths
- Add accessibility and keyboard navigation tests
- Test responsive behavior across multiple viewports
- Verify text overflow handling and RTL support

These tests ensure the fix in PR nextcloud#53788 properly constrains
the width of user actions to prevent profile layout distortion
when displaying long email addresses.
arturhg pushed a commit to arturhg/nextcloud-server that referenced this pull request Jul 4, 2025
- Add comprehensive E2E tests for profile page layout fix
- Test max-width constraints on user actions to prevent distortion
- Validate responsive behavior across different viewports
- Include edge cases for various email lengths and special scenarios
- Add CSS validation tests to ensure proper styling
- Create utility functions for profile testing
- Add visual regression tests with screenshots
- Test performance and layout stability

These tests ensure that long email addresses in profile actions
don't break the layout, as fixed in PR nextcloud#53788.
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Profile page - broken layout for not logged-in users

5 participants