-
-
Couldn't load subscription status.
- Fork 4.6k
fix(profile): add max width for the user actions #53788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the profile to look distorted when the primary action is a long email address. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/backport to stable31 |
skjnldsv
approved these changes
Jul 3, 2025
szaimen
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 tasks
arturhg
pushed a commit
to arturhg/nextcloud-server
that referenced
this pull request
Jul 4, 2025
- Add comprehensive E2E tests for profile max-width fix - Test long email addresses that would cause layout distortion - Validate CSS properties (max-width: 300px for user-actions) - Include visual regression tests for different email lengths - Add accessibility and keyboard navigation tests - Test responsive behavior across multiple viewports - Verify text overflow handling and RTL support These tests ensure the fix in PR nextcloud#53788 properly constrains the width of user actions to prevent profile layout distortion when displaying long email addresses.
arturhg
pushed a commit
to arturhg/nextcloud-server
that referenced
this pull request
Jul 4, 2025
- Add comprehensive E2E tests for profile page layout fix - Test max-width constraints on user actions to prevent distortion - Validate responsive behavior across different viewports - Include edge cases for various email lengths and special scenarios - Add CSS validation tests to ensure proper styling - Create utility functions for profile testing - Add visual regression tests with screenshots - Test performance and layout stability These tests ensure that long email addresses in profile actions don't break the layout, as fixed in PR nextcloud#53788.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
feature: profile
PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This prevents the profile to look distorted when the primary action is a long email address.
Checklist