-
-
Couldn't load subscription status.
- Fork 4.6k
feat(files_sharing): Toggle display for trusted server shares #53661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a848ee to
92e64f3
Compare
|
Tested the behavior. It works, but there are a few issues:
Proposals:
|
92e64f3 to
b95563e
Compare
1c29e9c to
6bb5bdc
Compare
|
/compile |
|
Psalm is related, the return types do not match anymore. |
c31bfcf to
2e8080c
Compare
f620ccd to
8995368
Compare
8995368 to
fc7eaa2
Compare
|
/compile |
1817e98 to
30bce1d
Compare
|
/compile |
12b9125 to
41e0753
Compare
41e0753 to
4c15167
Compare
|
/compile |
|
We have to force merge this, this has been for a while due to a the I looked at this with @susnux and we concluded the tests are not related and flaky as also elsewhere. |
859716e to
59cd4bc
Compare
59cd4bc to
83e557b
Compare
|
Meaning it was related because you moved the "create share" in the component to the bottom - adjusted the test code. |
|
@susnux one more rebase and recompile? :) |
Signed-off-by: nfebe <fenn25.fn@gmail.com>
83e557b to
2bb8c72
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Comments addressed, work needs to get in.
Thanks for double checking @susnux |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/53661/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2bb8c72c 21b273dc
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53661/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |

Exposes the trust status of federated shares in the Share API, allowing the frontend to filter them based on the new show_federated_shares_to_trusted_servers_as_internal setting.
Usage:
occ config:app:set files_sharing show_federated_shares_to_trusted_servers_as_internal --value true --type booleanScreenshots
Stable31 is trusted server and stable30 is not
Fixes #52635