Skip to content

fix(files_sharing): Stop hiding delete share button in advanced settings menu #53639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

fix(files_sharing): Stop hiding delete share button in advanced settings menu #53639

merged 2 commits into from
Jun 30, 2025

Conversation

@provokateurin
Copy link
Member

Summary

Deleting a share is not an "advanced setting", so the button should not be hidden if the menu is collapsed.

Before:

image

image

After:

image

image

Checklist

@provokateurin provokateurin added this to the Nextcloud 32 milestone Jun 23, 2025
@provokateurin provokateurin requested a review from a team as a code owner June 23, 2025 07:47
@provokateurin provokateurin requested review from artonge, skjnldsv and sorbaugh and removed request for a team June 23, 2025 07:47
@provokateurin
Copy link
Member Author

/backport to stable31

@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin provokateurin requested a review from susnux June 24, 2025 10:55
susnux
susnux reviewed Jun 30, 2025
View reviewed changes
susnux
susnux reviewed Jun 30, 2025
View reviewed changes
@provokateurin
fix(files_sharing): Stop hiding delete share button in advanced setti…
d55b1ee 
…ngs menu

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/files_sharing/advanced-settings-delete-share-button branch from 66dbe2a to d55b1ee Compare June 30, 2025 11:01
@provokateurin
Copy link
Member Author

/compile

@nextcloud-command
chore(assets): Recompile assets
f9153f8 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command requested a review from a team as a code owner June 30, 2025 11:08
@provokateurin provokateurin merged commit fbe4859 into master Jun 30, 2025
123 of 124 checks passed
@provokateurin provokateurin deleted the fix/files_sharing/advanced-settings-delete-share-button branch June 30, 2025 11:37
This was referenced Jun 30, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@yemkareems yemkareems yemkareems approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: sharing

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: "Delete Share" button is hidden behind "Custom permissions"

6 participants

@provokateurin @susnux @yemkareems @skjnldsv @nextcloud-command