Skip to content

fix(core): getRequestToken import typo #53534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

fix(core): getRequestToken import typo #53534

merged 2 commits into from
Jun 17, 2025

Conversation

@skjnldsv
Copy link
Member

Regression from #53326

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jun 17, 2025
@skjnldsv skjnldsv requested a review from susnux June 17, 2025 07:25
@skjnldsv skjnldsv self-assigned this Jun 17, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner June 17, 2025 07:25
@skjnldsv skjnldsv requested review from artonge and szaimen and removed request for a team June 17, 2025 07:25
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Jun 17, 2025
szaimen
szaimen approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux
Copy link
Contributor

susnux commented Jun 17, 2025

why did eslint not complain on this? On stable3{1,0} it did in install.js 👀

@skjnldsv @susnux
fix(core): getRequestToken import typo
a203968 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@susnux susnux force-pushed the fix/requesttoken branch from a6902cf to a203968 Compare June 17, 2025 09:14
@susnux
Copy link
Contributor

susnux commented Jun 17, 2025

/compile

@susnux susnux enabled auto-merge June 17, 2025 09:14
@skjnldsv
Copy link
Member Author

why did eslint not complain on this? On stable3{1,0} it did in install.js 👀

It did complain for me, this is how I found it :)

@nextcloud-command
chore(assets): Recompile assets
94d20a4 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command requested a review from a team as a code owner June 17, 2025 09:23
@solracsf
Copy link
Member

Backports?

@susnux
Copy link
Contributor

susnux commented Jun 17, 2025

It did complain for me, this is how I found it :)

CI was green on merge 👀

@susnux
Copy link
Contributor

susnux commented Jun 17, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Jun 17, 2025

/backport to stable30

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 17, 2025 •
edited
Loading

CI was green on merge 👀

Yeah, it's a warning

WARNING in ./core/src/OC/eventsource.js 30:50-58
export 'getToken' (imported as 'getToken') was not found in './requesttoken.ts' (possible exports: fetchRequestToken, getRequestToken, setRequestToken)
 @ ./core/src/OC/index.js 18:0-43 79:2-13
 @ ./core/src/login.js 9:0-31

@susnux susnux merged commit 7ebf775 into master Jun 17, 2025
132 of 136 checks passed
@susnux susnux deleted the fix/requesttoken branch June 17, 2025 11:04
This was referenced Jun 17, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv @susnux @solracsf @szaimen @nextcloud-command