Skip to content

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jun 14, 2025

Checklist

@solracsf
Copy link
Member Author

/backport to stable31

@solracsf solracsf added this to the Nextcloud 32 milestone Jun 14, 2025
@solracsf solracsf marked this pull request as ready for review June 14, 2025 13:53
@solracsf solracsf requested a review from a team as a code owner June 14, 2025 13:53
@solracsf solracsf requested review from artonge, come-nc, icewind1991, leftybournes, printminion-co, skjnldsv and yemkareems and removed request for a team June 14, 2025 13:53
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@come-nc
Copy link
Contributor

come-nc commented Jun 16, 2025

It feels weird to have this as a general option in config.php.

It should be an option for each storage defined in files_external, no? You may want to enable it for an SMB one on local network and disable it for another s3 storage? Or is that too niche?

@icewind1991
Copy link
Member

I agree that having this per storage would be better.

Additionally, allowing the admin to set a different cutoff size instead of just disabling the cutoff altogether would be nice.

Note that there is a "mount options" system that would probably make sense to use to configure this.

They can be set with occ files_external:option <mount id> <key> <value> and then checked with $file->getMountPoint()->getOption($key, $default)

@solracsf
Copy link
Member Author

Got it. 👍
In that case, i'm closing here in favour of a "per storage" option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Movie preview not generated on remote storages if file > 5MiB

5 participants