Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 5, 2025

This is being used to set the title and should be exposed to clients and the frontend

document.title = `${this.pageHeading} - ${getCapabilities().theming?.productName ?? 'Nextcloud'}`

@juliusknorr juliusknorr force-pushed the fix/product-name-capability branch from 880ce13 to 21cc315 Compare June 5, 2025 07:45
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jun 5, 2025
@juliusknorr juliusknorr requested review from skjnldsv and susnux June 5, 2025 07:45
@juliusknorr juliusknorr added this to the Nextcloud 32 milestone Jun 5, 2025
@juliusknorr juliusknorr marked this pull request as ready for review June 5, 2025 07:45
@juliusknorr juliusknorr requested a review from a team as a code owner June 5, 2025 07:45
@juliusknorr juliusknorr requested review from come-nc and yemkareems and removed request for a team June 5, 2025 07:45
@juliusknorr
Copy link
Member Author

/backport to stable31

@juliusknorr
Copy link
Member Author

/backport to stable30

@susnux
Copy link
Contributor

susnux commented Jun 5, 2025

See also #53321

But anyways it makes sense to pass the product name as capability

@juliusknorr juliusknorr force-pushed the fix/product-name-capability branch from 0525ffa to 842b414 Compare June 12, 2025 05:41
juliusknorr and others added 2 commits June 18, 2025 12:54
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/product-name-capability branch from 842b414 to 1d0915b Compare June 18, 2025 10:58
@susnux susnux requested a review from provokateurin as a code owner June 18, 2025 10:58
@susnux susnux merged commit 98871fe into master Jun 18, 2025
209 of 214 checks passed
@susnux susnux deleted the fix/product-name-capability branch June 18, 2025 15:10
@backportbot
Copy link

backportbot bot commented Jun 18, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/53339/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9f12d685 1d0915b3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53339/stable30

Error: Failed to push branch backport/53339/stable30: remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants