fix: refactor request token handling and do not update with invalid result #53326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
artonge,
skjnldsv and
sorbaugh
and removed request for
a team
|
Best to review commit by commit - most changes are tests only. |
|
/backport to stable31 |
|
/backport to stable30 |
skjnldsv
approved these changes
Jun 5, 2025
susnux
force-pushed
the
fix/requesttoken
branch
3 times, most recently
from
76ab7d3 to
8193a42
Compare
susnux
commented
Jun 11, 2025
susnux
commented
Jun 11, 2025
susnux
commented
Jun 11, 2025
susnux
commented
Jun 11, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…n reading order Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Jun 16, 2025
|
Thank you for this! The linked bug has been present for years, I really hope this is the end of it. |
solracsf
reviewed
Jun 16, 2025
| * Get interval in seconds | ||
| */ | ||
| function getInterval(): number { | ||
| const interval = seesionLifetime |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally this should have been only a refactoring to migrate the code to Typescript and add some more tests for it.
But doing so I discovered some issues within the logic that revealed to cause the linked issue (or to cause at least the frontend part of it).
The issue itself if likely to be orginally caused by some server issue (e.g. overloaded) which causes a 500 return, then we have an "undefined" token (as the old code did not check for the validity) and tried to update it.
This causes all following requests to use an invalid token.
Checklist