Skip to content

Conversation

@julien-nc
Copy link
Member

...when setting the page title in the file list.

Theming capabilities do not include productName but name is there. See https://github.com/nextcloud/server/blob/master/apps/theming/lib/Capabilities.php#L96-L110

The page title is overridden by <NcAppContent> anyway. There is mistake there too. The Files page title is always like:
A directory - All files - Nextcloud - THEMING_NAME
and I think we want it to be
A directory - All files - THEMING_NAME
like it is defined in core/templates/layout.user.php, right?

I will create an issue in nextcloud-vue and link it here.

@julien-nc julien-nc added this to the Nextcloud 32 milestone Jun 4, 2025
@julien-nc julien-nc requested review from a team and skjnldsv as code owners June 4, 2025 10:40
@julien-nc julien-nc added bug 3. to review Waiting for reviews labels Jun 4, 2025
@julien-nc julien-nc requested review from nfebe and susnux and removed request for a team June 4, 2025 10:40
@skjnldsv
Copy link
Member

skjnldsv commented Jun 4, 2025

Please use the app name for the commit message's scope :)
fix(files):

@julien-nc julien-nc force-pushed the fix/noid/files-page-heading-theming-name branch from 8a8a2e9 to de3315e Compare June 4, 2025 11:16
@susnux
Copy link
Contributor

susnux commented Jun 5, 2025

Alternative: #53339

Yes it should be the name.

julien-nc added 2 commits June 5, 2025 10:17
…o set the page title

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the fix/noid/files-page-heading-theming-name branch from de3315e to 91ed3b2 Compare June 5, 2025 08:26
@julien-nc julien-nc requested a review from a team as a code owner June 5, 2025 08:26
@juliusknorr
Copy link
Member

I think this is the logically more correct fix to use the instance name not product name, but would also merge #53339 in addition for cases where that is needed

@juliusknorr juliusknorr merged commit 609c25a into master Jun 5, 2025
124 checks passed
@juliusknorr juliusknorr deleted the fix/noid/files-page-heading-theming-name branch June 5, 2025 09:12
@susnux
Copy link
Contributor

susnux commented Jun 18, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Jun 18, 2025

/backport to stable30

@susnux
Copy link
Contributor

susnux commented Jun 18, 2025

/backport to stable30

@susnux
Copy link
Contributor

susnux commented Jun 18, 2025

/backport to stable29

@backportbot
Copy link

backportbot bot commented Jun 18, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/53321/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 01de909a 91ed3b2c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53321/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/53321/stable30."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Jun 18, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/53321/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 01de909a 91ed3b2c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53321/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants