fix(provisioning_api): Allow group details access for users with admin delegation #53275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yemkareems
approved these changes
Jun 3, 2025
I don't get how the move from annotation to attribute should be responsible for this? Maybe you didn't read the entire commit when checking the git blame. |
Right, sorry for git-blaming your commit, the issue then is simply the use of the middleware |
provokateurin
requested changes
Jun 3, 2025
…n delegation This fixes an issue where users with "Administration privileges → Users" could not access the groups details endpoint in the provisioning API, resulting in a 403 Forbidden error. There is a problem with adding the `AuthorizedAdminSetting` attribute (middleware) that only allows access to users with Sharing admin privileges. Users with "`Users` admin" privileges should also be able to access group details. Resolves: #52617 Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/52617/fix-group-admin-delegation
branch
from
ca148d6 to
b647ca6
Compare
provokateurin
approved these changes
Jun 3, 2025
|
/backport to stable31 |
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where users with "Administration privileges → Users" could not access the groups details endpoint in the provisioning API, resulting in a 403 Forbidden error.
There is a problem with adding the
AuthorizedAdminSettingattribute (middleware) that only allows access to users with Sharing admin privileges.Users with "
Usersadmin" privileges should also be able to access group details.Resolves: #52617
Introduced in : #46815