Skip to content

test: Migrate remaining DAV tests to PHPUnit 10 #53146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

test: Migrate remaining DAV tests to PHPUnit 10 #53146

merged 3 commits into from
May 28, 2025

Conversation

nickvergessen
Copy link
Member

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 32 milestone May 27, 2025
@nickvergessen nickvergessen self-assigned this May 27, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner May 27, 2025 21:39
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label May 27, 2025
@nickvergessen nickvergessen requested review from sorbaugh and removed request for a team May 27, 2025 21:39
@nickvergessen nickvergessen added the tests Related to tests label May 27, 2025
nickvergessen and others added 3 commits May 28, 2025 09:25
@nickvergessen @susnux
test: Migrate remaining DAV tests to PHPUnit 10
76e6ab1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @susnux
fix(DAV): Check if the header is actually the expected format
9978dcf 
Not sure how the test ever passed as it can only
throw with strict types which are not yet enabled

Signed-off-by: Joas Schilling <coding@schilljs.com>
@susnux
test(dav): adjust test cases for PHPUnit 10
9f8f775 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the tests/noid/finish-dav branch from ac8161a to 9f8f775 Compare May 28, 2025 07:30
@susnux
Copy link
Contributor

susnux commented May 28, 2025

@nickvergessen I took the liberty to fix the broken test, for returnMap you also need to set optional parameters with default values (for t it is the parameters array).

@nickvergessen
Copy link
Member Author

for returnMap you also need to set optional parameters with default values

I already wondered why it works locally… PHPUnit 10 will save that :D

@nickvergessen nickvergessen merged commit 56f3d19 into master May 28, 2025
192 checks passed
@nickvergessen nickvergessen deleted the tests/noid/finish-dav branch May 28, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@miaulalala miaulalala Awaiting requested review from miaulalala

@provokateurin provokateurin Awaiting requested review from provokateurin

@come-nc come-nc Awaiting requested review from come-nc

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews tests Related to tests
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @susnux @Antreesy