[stable31] feat(files_trashbin): Refactor expire background job to support parallel run #53026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
enhancement
3. to review
artonge
force-pushed
the
backport/52825/stable31
branch
from
dfd492b to
81de5af
Compare
artonge
approved these changes
May 21, 2025
backportbot
bot
force-pushed
the
backport/52825/stable31
branch
from
81de5af to
6e4c5d5
Compare
artonge
force-pushed
the
backport/52825/stable31
branch
2 times, most recently
from
3a65d5a to
a58b3e9
Compare
skjnldsv
added
the
♻️ refactor
|
@artonge merge? |
artonge
force-pushed
the
backport/52825/stable31
branch
3 times, most recently
from
69b7391 to
cd90ee4
Compare
backportbot
bot
force-pushed
the
backport/52825/stable31
branch
from
cd90ee4 to
c69e5d9
Compare
artonge
force-pushed
the
backport/52825/stable31
branch
from
c69e5d9 to
c069007
Compare
artonge
force-pushed
the
backport/52825/stable31
branch
from
c069007 to
7d1cdfe
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
…lel run - Follow-up of #51600 The original PR introduced the possibility to continue an `ExpireTrash` job by saving the offset. This was to prevent having to start over the whole user list when the job crashed or was killed. But on big instances, one process is not enough to go through all the users in a timely manner. Supporting parallel run allows covering more ground faster. This PR introduced this possibility. We are now storing the offset right away to allow another parallel job to pick up the task at that point. We are arbitrarily cutting the user list in chunk of 10 to not drastically overflow the 30 minutes time limit. Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
backport/52825/stable31
branch
from
7d1cdfe to
60455d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #52825
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.