feat(SetupChecks): Add check for TaskProcessing pickup speed #53001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
requested review from
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
ChristophWurst
approved these changes
May 20, 2025
julien-nc
approved these changes
May 21, 2025
marcelklehr
force-pushed
the
feat/setupcheck-task-pickup-speed
branch
2 times, most recently
from
038149d to
3832197
Compare
ChristophWurst
approved these changes
May 22, 2025
Comment on lines
+40
to
+72
| public function testPass(): void { | ||
| $tasks = []; | ||
| for ($i = 0; $i < 100; $i++) { | ||
| $task = new Task('test', ['test' => 'test'], 'settings', 'user' . $i); | ||
| $task->setStartedAt(0); | ||
| if ($i < 15) { | ||
| $task->setScheduledAt(60 * 5); // 15% get 5mins | ||
| } else { | ||
| $task->setScheduledAt(60); // the rest gets 1min | ||
| } | ||
| $tasks[] = $task; | ||
| } | ||
| $this->taskProcessingManager->method('getTasks')->willReturn($tasks); | ||
|
|
||
| $this->assertEquals(SetupResult::SUCCESS, $this->check->run()->getSeverity()); | ||
| } | ||
|
|
||
| public function testFail(): void { | ||
| $tasks = []; | ||
| for ($i = 0; $i < 100; $i++) { | ||
| $task = new Task('test', ['test' => 'test'], 'settings', 'user' . $i); | ||
| $task->setStartedAt(0); | ||
| if ($i < 30) { | ||
| $task->setScheduledAt(60 * 5); // 30% get 5mins | ||
| } else { | ||
| $task->setScheduledAt(60); // the rest gets 1min | ||
| } | ||
| $tasks[] = $task; | ||
| } | ||
| $this->taskProcessingManager->method('getTasks')->willReturn($tasks); | ||
|
|
||
| $this->assertEquals(SetupResult::WARNING, $this->check->run()->getSeverity()); | ||
| } |
ChristophWurst
added
enhancement
4. to release
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
feat/setupcheck-task-pickup-speed
branch
from
3832197 to
f8f2695
Compare
|
If backported, #53068 also needs backporting |
|
/backport to stable31 |
|
/backport to stable30 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A lot of people complain about slow AI task execution, which is usually due to slow pickup speed, which is usually due to people not setting up a worker, which is usually because people do not read the docs. So, let's tell them to read the docs if it becomes an issue.
Checklist