- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.6k
Replace "remove" wording with "delete" #52897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "remove" wording with "delete" #52897
Conversation
3a9cc8f    to
    b91571d      
    Compare
  
    b91571d    to
    0bec33d      
    Compare
  
    | - Replace "remove" wording with "delete"
- npm run build
+ refactor(settings): replace "remove" wording with "delete"
+ chore: recompile assets | 
0bec33d    to
    8e5d017      
    Compare
  
    | 
 I'll take a look at it later this week @susnux | 
| @Jerome-Herbinet also cypress tests needs adjusting Search for the old strings in the cypress tests folder | 
8e5d017    to
    483ae9a      
    Compare
  
    894ee3e    to
    3700429      
    Compare
  
    | @susnux it's OK, I updated the branch and changed commits' names. Is the cypress issue fixed ? | 
| 
 You need to do it | 
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
dd46843    to
    54a58c0      
    Compare
  
    | 
 @susnux I replaced "Remove group" with "Delete group" in Cypress ; hope that it will all work. | 
| Hi everyone :) Cypress tests have failed again. | 
| 
 this time it looks like it crashed aha, bad luck :) | 
| Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) | 

This is more direct and understandable.
"Remove" may suggest that the group will remain somewhere, whereas "Delete" leaves no doubt.
Next, the popup message specifies that users will not be deleted.
Summary
TODO
Checklist