Skip to content

Conversation

@Jerome-Herbinet
Copy link
Member

This is more direct and understandable.
"Remove" may suggest that the group will remain somewhere, whereas "Delete" leaves no doubt.
Next, the popup message specifies that users will not be deleted.

  • Resolves: #

Summary

TODO

  • ...

Checklist

@Jerome-Herbinet Jerome-Herbinet requested a review from a team as a code owner May 16, 2025 09:52
@Jerome-Herbinet Jerome-Herbinet requested review from nfebe, skjnldsv and susnux and removed request for a team May 16, 2025 09:52
@Jerome-Herbinet Jerome-Herbinet requested a review from a team as a code owner May 16, 2025 09:56
@susnux
Copy link
Contributor

susnux commented May 16, 2025

@Jerome-Herbinet please use conventional commits

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-replace-remove-wording-with-delete branch from 3a9cc8f to b91571d Compare May 16, 2025 11:23
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-replace-remove-wording-with-delete branch from b91571d to 0bec33d Compare May 16, 2025 12:49
@susnux
Copy link
Contributor

susnux commented May 16, 2025

- Replace "remove" wording with "delete"
- npm run build
+ refactor(settings): replace "remove" wording with "delete"
+ chore: recompile assets

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-replace-remove-wording-with-delete branch from 0bec33d to 8e5d017 Compare May 19, 2025 06:56
@Jerome-Herbinet
Copy link
Member Author

- Replace "remove" wording with "delete"
- npm run build
+ refactor(settings): replace "remove" wording with "delete"
+ chore: recompile assets

I'll take a look at it later this week @susnux

@skjnldsv
Copy link
Member

@Jerome-Herbinet also cypress tests needs adjusting
image

Search for the old strings in the cypress tests folder

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-replace-remove-wording-with-delete branch from 8e5d017 to 483ae9a Compare May 22, 2025 14:02
@Jerome-Herbinet
Copy link
Member Author

- Replace "remove" wording with "delete"
- npm run build
+ refactor(settings): replace "remove" wording with "delete"
+ chore: recompile assets

I'll take a look at it later this week @susnux

Done @susnux

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-replace-remove-wording-with-delete branch 2 times, most recently from 894ee3e to 3700429 Compare May 22, 2025 14:18
@Jerome-Herbinet
Copy link
Member Author

@susnux it's OK, I updated the branch and changed commits' names. Is the cypress issue fixed ?

@skjnldsv
Copy link
Member

Is the cypress issue fixed ?

You need to do it

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-replace-remove-wording-with-delete branch from dd46843 to 54a58c0 Compare May 23, 2025 07:48
@Jerome-Herbinet
Copy link
Member Author

Is the cypress issue fixed ?

You need to do it

@susnux I replaced "Remove group" with "Delete group" in Cypress ; hope that it will all work.

@zak39
Copy link
Contributor

zak39 commented May 23, 2025

Hi everyone :)

Cypress tests have failed again.
However, I have the impression that the one of Cypress tests has crashed : https://github.com/nextcloud/server/actions/runs/15205178488/job/42766873523?pr=52897

@skjnldsv
Copy link
Member

Hi everyone :)

Cypress tests have failed again. However, I have the impression that the one of Cypress tests has crashed : nextcloud/server/actions/runs/15205178488/job/42766873523?pr=52897

this time it looks like it crashed aha, bad luck :)
I restarted it

@skjnldsv skjnldsv enabled auto-merge May 24, 2025 07:58
@skjnldsv skjnldsv merged commit 8864e9b into master May 24, 2025
134 of 136 checks passed
@skjnldsv skjnldsv deleted the Jerome-Herbinet-replace-remove-wording-with-delete branch May 24, 2025 07:59
@skjnldsv
Copy link
Member

/backport 41dc76c 54a58c0 to stable31

@skjnldsv
Copy link
Member

/backport 41dc76c 54a58c0 to stable30

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants