-
-
Couldn't load subscription status.
- Fork 4.6k
Add command to clear dav's photo cache #52879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
f367139 to
3d1de79
Compare
ChristophWurst
approved these changes
May 15, 2025
hamza221
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
|
/backport 8a1ae09 to stable31 |
2 tasks
|
/backport 8a1ae09 to stable30 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contacts is using a request like below to fetch the photo for a user from the vcard.
/remote.php/dav/addressbooks/users/alice/z-server-generated--system/Database:jane.vcf?photoAs fetching and parsing vcards might be expensive there's a cache for the photos in app-data. While there are event listeners in place to reset the cache for a vcard on update or delete, there might be still cases where it's helpful to clear the cache.
How to test:
'%dav-photocache%''%dav-photocache%''%dav-photocache%'Backports:
Only the command, refactoring is for 32.
Checklist