Skip to content

Conversation

@AndyXheli
Copy link
Contributor

Since this PR #52221 was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to debug

Original PR
#52221

  • Resolves: #

Summary

TODO

  • ...

Checklist

Since this PR nextcloud#52221 was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to debug

Original PR
nextcloud#52221

Signed-off-by: AndyXheli <andyxheli@gmail.com>
@AndyXheli AndyXheli requested a review from a team as a code owner May 15, 2025 12:34
@AndyXheli AndyXheli requested review from come-nc, nfebe and provokateurin and removed request for a team May 15, 2025 12:34
@AndyXheli
Copy link
Contributor Author

Hey @joshtrichards Sorry i created a new PR Git desktop messed something up on the other one. sorry about that again

@susnux susnux added this to the Nextcloud 32 milestone May 15, 2025
@provokateurin provokateurin enabled auto-merge May 15, 2025 12:58
@provokateurin
Copy link
Member

/backport to stable31

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2025
@ChristophWurst ChristophWurst disabled auto-merge May 16, 2025 08:42
@ChristophWurst ChristophWurst merged commit 47c0786 into nextcloud:master May 16, 2025
177 of 180 checks passed
@ChristophWurst
Copy link
Member

Force merged because CI didn't run for the fork and risk seemed low

Thank you @AndyXheli

@AndyXheli AndyXheli deleted the patch-2 branch May 16, 2025 13:22
@nigelharpur
Copy link

Thank you to all involved in the fix, appreciate these things are complex procedures. If one of you has a moment to briefly say exactly when the fix will be implemented in an official release that would be most appreciated.

I've been daily deleting the 50+ log entries and from what I read in the github entries I can't really see whether 'something is wrong' or not tbh. The fix appears to be to stop it being reported at the current log level? So is it just reporting functions to be expected?

It is difficult for admins at my level (able to run a self hosted Nextcloud OK but certainly not a coder) to follow what's going on as the jargon of the devs' world leaves me guessing a lot of the time - 'my bad' I know!

@come-nc
Copy link
Contributor

come-nc commented May 26, 2025

Thank you to all involved in the fix, appreciate these things are complex procedures. If one of you has a moment to briefly say exactly when the fix will be implemented in an official release that would be most appreciated.

I've been daily deleting the 50+ log entries and from what I read in the github entries I can't really see whether 'something is wrong' or not tbh. The fix appears to be to stop it being reported at the current log level? So is it just reporting functions to be expected?

It is difficult for admins at my level (able to run a self hosted Nextcloud OK but certainly not a coder) to follow what's going on as the jargon of the devs' world leaves me guessing a lot of the time - 'my bad' I know!

The fix lowers the level of the message from warning to debug. I believe this was never a problem to begin with, only a too-high level for a debug log message.
The fix is in 31.0.6 and higher, and will be in 32 as well.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: logging feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Spamming Logs Cached preview not found for file generating a new preview.

7 participants