-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(previews): lower log level when cached preview isn't found #52871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since this PR nextcloud#52221 was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to debug Original PR nextcloud#52221 Signed-off-by: AndyXheli <andyxheli@gmail.com>
|
Hey @joshtrichards Sorry i created a new PR Git desktop messed something up on the other one. sorry about that again |
|
/backport to stable31 |
|
Force merged because CI didn't run for the fork and risk seemed low Thank you @AndyXheli |
|
Thank you to all involved in the fix, appreciate these things are complex procedures. If one of you has a moment to briefly say exactly when the fix will be implemented in an official release that would be most appreciated. I've been daily deleting the 50+ log entries and from what I read in the github entries I can't really see whether 'something is wrong' or not tbh. The fix appears to be to stop it being reported at the current log level? So is it just reporting functions to be expected? It is difficult for admins at my level (able to run a self hosted Nextcloud OK but certainly not a coder) to follow what's going on as the jargon of the devs' world leaves me guessing a lot of the time - 'my bad' I know! |
The fix lowers the level of the message from warning to debug. I believe this was never a problem to begin with, only a too-high level for a debug log message. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Since this PR #52221 was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to debug
Original PR
#52221
Summary
TODO
Checklist