fix(files_sharing): Show note if note exists on share #52813
Merged
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/52794/share-advanced-settings
branch
from
7af74d5 to
ced4257
Compare
|
/compile |
susnux
approved these changes
May 14, 2025
artonge
approved these changes
May 14, 2025
When a share includes a note, ensure the note checkbox is checked and the note is displayed when reopening the share sidebar. Fixes: #52794. Signed-off-by: nfebe <fenn25.fn@gmail.com>
If a share note is present, the advanced settings should expand automatically, without the user needing to click. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
force-pushed
the
fix/52794/share-advanced-settings
branch
from
d2c11c7 to
86c591b
Compare
skjnldsv
approved these changes
May 14, 2025
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
2 tasks
2 tasks
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/52813/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 63cf3f53 7810a900 86c591ba
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52813/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@nfebe backport to 29 failed, see #52813 (comment) |
|
I tried backporting from 30, but it failed as well. I’ll try again, and if it still doesn’t work, I’ll resort to a manual backport as a last step. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a share includes a note, ensure the note checkbox is checked and the note is displayed when reopening the share sidebar.
Fixes: #52794