Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented May 12, 2025

Resolves:

Error: Call to a member function getValue() on null
#6 /var/www/nextcloud/lib/private/Calendar/Manager.php(333): OC\Calendar\Manager::handleIMipReply
#5 /mail/lib/Service/IMipService.php(149): OCA\Mail\Service\IMipService::process
#4 /mail/lib/BackgroundJob/IMipMessageJob.php(29): OCA\Mail\BackgroundJob\IMipMessageJob::run
#3 /var/www/nextcloud/lib/public/BackgroundJob/Job.php(61): OCP\BackgroundJob\Job::start
#2 /var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php(97): OCP\BackgroundJob\TimedJob::start
#1 /var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php(84): OCP\BackgroundJob\TimedJob::execute
#0 /var/www/nextcloud/cron.php(170): null

Summary

  • Added addition check to make sure properties exist
  • Added addition test

Checklist

@SebastianKrupinski SebastianKrupinski self-assigned this May 12, 2025
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label May 12, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team May 12, 2025
@SebastianKrupinski SebastianKrupinski marked this pull request as ready for review May 12, 2025 19:07
@SebastianKrupinski SebastianKrupinski requested a review from a team as a code owner May 12, 2025 19:07
@SebastianKrupinski SebastianKrupinski requested review from nfebe, skjnldsv and yemkareems and removed request for a team May 12, 2025 19:07
@SebastianKrupinski
Copy link
Contributor Author

/backport to 31

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the fix/noid-check-for-properties-before-processing branch from 4530184 to ebd80bc Compare May 12, 2025 19:44
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@ChristophWurst ChristophWurst merged commit 8c68f1e into master May 13, 2025
193 of 198 checks passed
@ChristophWurst ChristophWurst deleted the fix/noid-check-for-properties-before-processing branch May 13, 2025 16:58
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team May 13, 2025
@backportbot
Copy link

backportbot bot commented May 13, 2025

The backport to 31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout 31
git pull origin 31

# Create the new backport branch
git checkout -b backport/52778/31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ebd80bc1

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52778/31

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/52778/31')
fatal: not a valid object name: 'origin/31'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@ChristophWurst
Copy link
Member

/backport to stable31

@SebastianKrupinski
Copy link
Contributor Author

When you miss type the branch name in the backport commad 🫏 🫏

@solracsf
Copy link
Member

Is it possible to backport this PR to 30?

@st3iny
Copy link
Member

st3iny commented Jul 28, 2025

Is it possible to backport this PR to 30?

@SebastianKrupinski Is there a reason for not backporting further, for example, the fixed code is missing on stable30?

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable30

@SebastianKrupinski
Copy link
Contributor Author

@SebastianKrupinski Is there a reason for not backporting further, for example, the fixed code is missing on stable30?

There was a reason, but I don't remember the reason now, I'll backport it this morning.

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Development

Successfully merging this pull request may close these issues.

5 participants